Improve secp key handling and deployment reliability#13
Open
robertkodra wants to merge 1 commit intokeep-starknet-strange:feat/ethereum-signerfrom
Open
Improve secp key handling and deployment reliability#13robertkodra wants to merge 1 commit intokeep-starknet-strange:feat/ethereum-signerfrom
robertkodra wants to merge 1 commit intokeep-starknet-strange:feat/ethereum-signerfrom
Conversation
0xLucqs
reviewed
Feb 9, 2026
| const uncompressed = secp256k1.getPublicKey(this.privateKey, false); | ||
| const x = "0x" + bytesToHex(uncompressed.slice(1, 33)); | ||
| const y = "0x" + bytesToHex(uncompressed.slice(33, 65)); | ||
| this.publicKey = JSON.stringify({ x, y }); |
Contributor
There was a problem hiding this comment.
seems weird to me to store the public key as a json string
micbakos
reviewed
Feb 9, 2026
| let result = 0n; | ||
| for (const byte of bytes) { | ||
| result = (result << 8n) | BigInt(byte); | ||
| function normalizeHashHex(hash: string): string { |
Contributor
There was a problem hiding this comment.
Could we instead use this starknet.js function?
| "vitest": "^4.0.17" | ||
| }, | ||
| "dependencies": { | ||
| "@noble/curves": "^1.9.7", |
Contributor
There was a problem hiding this comment.
@0xLucqs Just to make sure can you check if this needs to be polyfilled for mobile integration?
Contributor
There was a problem hiding this comment.
only required for getRandomValues https://github.com/paulmillr/noble-curves?tab=readme-ov-file#usage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.