Fix TOTP detection that are password fields (like HackerOne) #2333
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This needs to be validated for regressions before merging. |
varjolintu
reviewed
Sep 7, 2024
| @@ -1,7 +1,7 @@ | |||
| 'use strict'; | |||
|
|
|||
| const ignoreRegex = /(bank|coupon|postal|user|zip).*code|comment|author|error/i; | |||
| const ignoredTypes = [ 'email', 'password', 'username' ]; | |||
There was a problem hiding this comment.
I'm not sure why password was removed. Standard TOTP fields aren't password fields, so this should be kept.
There was a problem hiding this comment.
See #2332 solution one, sometimes TOTP fields do have type=password.
Another solution would be the second one (an explicit accept), then the type!=password would also be bypassed.
There was a problem hiding this comment.
Instead of making this change global, I'd suggest adding an exception for this site's TOTP detection to the sites.js.
varjolintu
requested changes
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2332