Implement T-CONV and T-REPLACE-RX entry placeholders #11453
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
varjolintu
reviewed
Nov 9, 2024
droidmonkey
force-pushed
the
feature/conv-regex-placeholder
branch
from
71b437c to
395c93f
Compare
varjolintu
approved these changes
Nov 13, 2024
Member
varjolintu
left a comment
varjolintu
left a comment
There was a problem hiding this comment.
Works great. Tried it also with invalid values and ignored the UI warnings to check if the application complains about them when launching Auto-Type or opening a cmd URL.
* Closes #7293 * Move existing T-CONV and T-REPLACE-RX code from AutoType to Entry. Replumb AutoType to use the entry functions. * Improve placeholder code in various place
droidmonkey
force-pushed
the
feature/conv-regex-placeholder
branch
from
395c93f to
1dd1039
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #11453 +/- ##
===========================================
+ Coverage 63.84% 63.87% +0.03%
===========================================
Files 362 362
Lines 38115 38134 +19
===========================================
+ Hits 24334 24358 +24
+ Misses 13781 13776 -5 ☔ View full report in Codecov by Sentry. |
phoerious
added
pr: new feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing strategy
Added unit tests
Type of change