-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Implement Group sync for KeeShare #11593
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
❌ Your patch check has failed because the patch coverage (20.51%) is below the target coverage (50.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## develop #11593 +/- ##
===========================================
- Coverage 63.92% 63.86% -0.06%
===========================================
Files 369 369
Lines 38924 38953 +29
===========================================
- Hits 24880 24877 -3
- Misses 14044 14076 +32 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
e1fa1b8
to
64feaa8
Compare
I fixed up the code, but this does break existing behavior since recursing is off by default. Need to think about whether to send this out with 2.7.10 or not. |
This needs to be adjusted so the current behavior is retained as the default behavior. |
Deferring this to 2.8.0 |
Originally contributed through #9778, code provided by @evur
Fixes #3045
Screenshots
Testing strategy
Type of change