Implement Group sync for KeeShare

[droidmonkey]

Originally contributed through #9778, code provided by @evur

Fixes #3045

Screenshots

Testing strategy

Type of change

• ✅ Bug fix (non-breaking change that fixes an issue)
• ✅ New feature (change that adds functionality)

[codecov]

Codecov Report

❌ Patch coverage is 26.08696% with 34 lines in your changes missing coverage. Please review.
✅ Project coverage is 64.34%. Comparing base (9031cb5) to head (27a50d8).
⚠️ Report is 25 commits behind head on develop.

Files with missing lines	Patch %	Lines
src/keeshare/ShareExport.cpp	0.00%	25 Missing ⚠️
src/keeshare/group/EditGroupWidgetKeeShare.cpp	33.33%	6 Missing ⚠️
src/keeshare/KeeShareSettings.cpp	75.00%	3 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop   #11593      +/-   ##
===========================================
- Coverage    64.39%   64.34%   -0.05%     
===========================================
  Files          378      378              
  Lines        39782    39813      +31     
===========================================
+ Hits         25615    25616       +1     
- Misses       14167    14197      +30     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[droidmonkey]

I fixed up the code, but this does break existing behavior since recursing is off by default. Need to think about whether to send this out with 2.7.10 or not.

[droidmonkey]

This needs to be adjusted so the current behavior is retained as the default behavior.

[droidmonkey]

Deferring this to 2.8.0

[droidmonkey]

This is ready to go, greatly improves experience with KeeShare without completely overhauling it. @phoerious

[Copilot]

Pull Request Overview

This PR adds a "Keep Group Structure" checkbox to the KeeShare export functionality, allowing users to optionally preserve the hierarchical group structure when exporting shared databases. Previously, all entries from a shared group were flattened into the root of the export database.

• Adds a new keepGroups boolean field to the Reference struct (defaults to true for new references)
• Implements serialization/deserialization of the new field with backward compatibility
• Adds UI checkbox in the KeeShare group edit dialog to control this setting

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
src/keeshare/group/EditGroupWidgetKeeShare.ui	Adds a checkbox UI element at row 3 with layout adjustments for existing elements
src/keeshare/group/EditGroupWidgetKeeShare.h	Declares the slot handler for the new checkbox toggle event
src/keeshare/group/EditGroupWidgetKeeShare.cpp	Implements signal connection, checkbox state initialization, and toggle handler
src/keeshare/ShareExport.cpp	Refactors export logic to conditionally clone child groups based on keepGroups setting
src/keeshare/KeeShareSettings.h	Adds keepGroups field to Reference struct with default value true
src/keeshare/KeeShareSettings.cpp	Implements serialization/deserialization logic with backward compatibility and changes log level from warning to debug
share/translations/keepassxc_en.ts	Adds translation entries for the new checkbox label and tooltip

Comments suppressed due to low confidence (1)

src/keeshare/group/EditGroupWidgetKeeShare.ui:224

• The tab order does not include the newly added keepGroupsCheckbox widget. Add <tabstop>keepGroupsCheckbox</tabstop> after passwordEdit to ensure proper keyboard navigation through all form fields.

 <tabstops>
  <tabstop>typeComboBox</tabstop>
  <tabstop>pathEdit</tabstop>
  <tabstop>pathSelectionButton</tabstop>
  <tabstop>passwordEdit</tabstop>
  <tabstop>clearButton</tabstop>
 </tabstops>

[elRicharde]

Deferring this to 2.8.0

this can´t go to 2.7.11 i guess?

Thanks for your work, happy to see this on the way! :-)

[at-ng]

Milestone v2.7.11

droidmonkey modified the milestones: v2.8.0, v2.7.11 2 weeks ago

Preview builds https://snapshot.keepassxc.org/

[elRicharde]

Preview builds https://snapshot.keepassxc.org/

these are all 2.8 and the win11 latest crashes when unlocking my DB.
Anyways i prefer a released Version - happy to see it almost here. Thanks Team!

[droidmonkey]

Crashes? You should open an issue for that.

[tomasss1024]

Please ensure that the manual is updated to reflect this change and clarify the backward compatibility aspect. I was surprised to find that my databases were not synchronized after update to v2.7.11 and that only "root" items appeared in the shared file.