Skip to content

Implement Group sync for KeeShare #11593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

Implement Group sync for KeeShare #11593

wants to merge 4 commits into from

Conversation

droidmonkey
Copy link
Member

@droidmonkey droidmonkey commented Dec 24, 2024

Originally contributed through #9778, code provided by @evur

Fixes #3045

Screenshots

Testing strategy

Type of change

  • ✅ Bug fix (non-breaking change that fixes an issue)
  • ✅ New feature (change that adds functionality)

@droidmonkey droidmonkey added feature: KeeShare pr: new feature Pull request that adds a new feature labels Dec 24, 2024
@droidmonkey droidmonkey added this to the v2.7.10 milestone Dec 24, 2024
Copy link

codecov bot commented Dec 24, 2024

Codecov Report

Attention: Patch coverage is 20.51282% with 31 lines in your changes missing coverage. Please review.

Project coverage is 63.86%. Comparing base (dff5f3b) to head (06f9ab6).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
src/keeshare/ShareExport.cpp 0.00% 25 Missing ⚠️
src/keeshare/group/EditGroupWidgetKeeShare.cpp 33.33% 6 Missing ⚠️

❌ Your patch check has failed because the patch coverage (20.51%) is below the target coverage (50.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #11593      +/-   ##
===========================================
- Coverage    63.92%   63.86%   -0.06%     
===========================================
  Files          369      369              
  Lines        38924    38953      +29     
===========================================
- Hits         24880    24877       -3     
- Misses       14044    14076      +32     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@droidmonkey
Copy link
Member Author

I fixed up the code, but this does break existing behavior since recursing is off by default. Need to think about whether to send this out with 2.7.10 or not.

@droidmonkey
Copy link
Member Author

This needs to be adjusted so the current behavior is retained as the default behavior.

@droidmonkey droidmonkey modified the milestones: v2.7.10, v2.8.0 Feb 9, 2025
@droidmonkey
Copy link
Member Author

Deferring this to 2.8.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature: KeeShare pr: new feature Pull request that adds a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ability to sync group structure with KeeShare
3 participants