Added new cli flag to enable quick unlock even when --pw-stdin is passed as argument #12003
+38
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
findus
force-pushed
the
pw-stdin-quick-unlock
branch
3 times, most recently
from
b3d71be to
8d2d9fd
Compare
findus
force-pushed
the
pw-stdin-quick-unlock
branch
from
8d2d9fd to
2e54036
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the suggested flag to have quick unlock enabled on demand when unlocking with --pw-stdin .
Right now I only tested this on Linux, the logic that I changed got introduced by the Windows Hello Feature, so I think some more testing needs to be done on windows if the unlock dialog still behaves correctly in all cases.
Fixes:
#9957
#9023
Does not fix:
#9957 (comment)
Screenshots
Testing strategy
Type of change