Remove redundant root slash for absolute paths #12802
Open
+3
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Having an absolute path with two starting slashes can lead to issues with browsers like Tor Browser and sandboxes like AppArmor. The former defaults to https:// if two slashes are supplied. Even though the code explicitly states file://, this can still happen on systems like Linux, because the open functions eventually call gio, which removes the file:// prefix before passing the URI as argument to a program. AppArmor rejects read access even if configuration allows access (configured with one slash), so a contained browser like Firefox, which defaults to file://, could not open the html files. Since paths are already set to absolute paths through dataPath call, this additional slash can be removed in open functions.
Member
|
This isnt redundant, it is necessary, at least when I coded this in originally |
Contributor
Author
Can you elaborate what the requirement for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having an absolute path with two starting slashes can lead to issues with browsers like Tor Browser and sandboxes like AppArmor.
The former defaults to https:// if two slashes are supplied. Even though the code explicitly states file://, this can still happen on systems like Linux, because the open functions eventually call gio, which removes the file:// prefix before passing the URI as argument to a program.
AppArmor rejects read access even if configuration allows access (configured with one slash), so a contained browser like Firefox, which defaults to file://, could not open the html files.
Since paths are already set to absolute paths through dataPath call, this additional slash can be removed in open functions.
See also Tails issue 18477. This fixes the KeePassXC part, the AppArmor adjustment has to be done in Tails.
Testing strategy
With a contained AppArmor browser set as default application for HTML files, try to open the user guide through help menu and this configuration, which denies access to everything within /usr/share/keepassxc, but grants access to /usr/share/keepassxc/docs and its files:
Access is denied without this patch.
Type of change