Add support for Related Origin Requests with passkeys#12971
Open
varjolintu wants to merge 1 commit intokeepassxreboot:developfrom
Open
Add support for Related Origin Requests with passkeys#12971varjolintu wants to merge 1 commit intokeepassxreboot:developfrom
varjolintu wants to merge 1 commit intokeepassxreboot:developfrom
Conversation
varjolintu
added
feature: Passkeys
pr: new feature
droidmonkey
force-pushed
the
feature/passkeys_related_origin_requests
branch
from
d6cce3e to
9511a5d
Compare
varjolintu
force-pushed
the
feature/passkeys_related_origin_requests
branch
from
9511a5d to
61cb573
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements Related Origin Requests to the passkeys feature. It allows user to create and authenticate a passkey when RP ID differs from the page's actual origin.
For example, when creating a passkey to Facebook, the RP ID is
accounts.meta.comwhile page origin is https://accountscenter.facebook.com. The site provides a Related Origin Requests list at https://accounts.meta.com/.well-known/webauthn which is downloaded by the extension. The origin is listed there, KeePassXC identifies it, and allows user to create the passkey. Same check applies when authenticating to a site.Spec: https://www.w3.org/TR/webauthn-3/#sctn-related-origins
Extension side PR: keepassxreboot/keepassxc-browser#2828
Testing strategy
Creating a passkey to Facebook should now work with the added feature. Microsoft and Amazon also uses Related Origin Requests, so a passkey created with e.g. amazon.de should work with amazon.com.
Automatic tests added for creation and authentication (to the point where the Related Origin Requests list is succesfully parsed).
Type of change