Skip to content

fix: Address #12631 with activeModalWidget() checks#12979

Open
Jesssullivan wants to merge 2 commits intokeepassxreboot:developfrom
Jesssullivan:develop
Open

fix: Address #12631 with activeModalWidget() checks#12979
Jesssullivan wants to merge 2 commits intokeepassxreboot:developfrom
Jesssullivan:develop

Conversation

@Jesssullivan
Copy link

@Jesssullivan Jesssullivan commented Jan 19, 2026

Hi there!

This is a pass at addressing #12631; I bumped into this as well.

I just added activeModalWidget() checks in src/gui/DatabaseWidget.cpp; AFAICT this is all that is needed, though I am new to this codebase.

Testing strategy

  • added a test to verify activeModalWidget()'s intended blocking behavior in TestGui; noting I am unfamiliar with this test setup.
  • Ran through the tests locally on 26.2 (25C56), apple silicon (m3). Would appreciate some pointers on how others are running local multiarch tests.

Type of change

  • ✅ Bug fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant