Fix sshAgent casacading calls with QSignalBlocker#13068
Open
AlexpFr wants to merge 1 commit intokeepassxreboot:developfrom
Open
Fix sshAgent casacading calls with QSignalBlocker#13068AlexpFr wants to merge 1 commit intokeepassxreboot:developfrom
AlexpFr wants to merge 1 commit intokeepassxreboot:developfrom
Conversation
e4b0746 to
e05f0d6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: block SSH agent signals on programmatic UI updates
Block
attachmentComboBox/externalFileEdit/m_attachments.data()signals from emitting when changed by code (not user interaction). Uses QSignalBlocker pattern.Functions affected:
setForm()clear()setSSHAgentSetting()updateSSHAgentAttachments()These modify UI elements, trigger unwanted signals, and recursively call:
updateSSHAgentKeyInfo()updateSSHAgentAttachment()updateSSHAgentAttachments()Implementation:
Add QSignalBlocker on programmatic changes:
Testing strategy
-DWITH_XC_SSHAGENT=ONType of change