Skip to content

Fix sshAgent casacading calls with QSignalBlocker#13068

Open
AlexpFr wants to merge 1 commit intokeepassxreboot:developfrom
AlexpFr:fix/sshAgent-cascading-calls-QSignalBlocker
Open

Fix sshAgent casacading calls with QSignalBlocker#13068
AlexpFr wants to merge 1 commit intokeepassxreboot:developfrom
AlexpFr:fix/sshAgent-cascading-calls-QSignalBlocker

Conversation

@AlexpFr
Copy link
Copy Markdown
Contributor

@AlexpFr AlexpFr commented Feb 18, 2026

fix: block SSH agent signals on programmatic UI updates

Block attachmentComboBox/externalFileEdit/m_attachments.data() signals from emitting when changed by code (not user interaction). Uses QSignalBlocker pattern.

Functions affected:

  • setForm()
  • clear()
  • setSSHAgentSetting()
  • updateSSHAgentAttachments()

These modify UI elements, trigger unwanted signals, and recursively call:

  • updateSSHAgentKeyInfo()
  • updateSSHAgentAttachment()
  • updateSSHAgentAttachments()

Implementation:
Add QSignalBlocker on programmatic changes:

QSignalBlocker sshAgent_attachmentComboBox_Blocker(m_sshAgentUi->attachmentComboBox);
QSignalBlocker sshAgent_externalFileEdit_Blocker(m_sshAgentUi->externalFileEdit);
QSignalBlocker attachmentsBlocker(m_attachments.data());

Testing strategy

Type of change

  • ✅ Bug fix (non-breaking change that fixes an issue)

@droidmonkey droidmonkey force-pushed the fix/sshAgent-cascading-calls-QSignalBlocker branch from e4b0746 to e05f0d6 Compare March 15, 2026 00:01
@droidmonkey droidmonkey added feature: SSH agent pr: bugfix Pull request fixes a bug labels Mar 15, 2026
@droidmonkey droidmonkey added this to the v2.8.0 milestone Mar 15, 2026
@droidmonkey droidmonkey self-requested a review March 15, 2026 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature: SSH agent pr: bugfix Pull request fixes a bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants