Skip to content

Rename Chinese language items to "Simplified/Traditional Chinese"#13129

Merged
droidmonkey merged 2 commits intokeepassxreboot:developfrom
yjdyamv:develop
Mar 14, 2026
Merged

Rename Chinese language items to "Simplified/Traditional Chinese"#13129
droidmonkey merged 2 commits intokeepassxreboot:developfrom
yjdyamv:develop

Conversation

@yjdyamv
Copy link
Copy Markdown
Contributor

@yjdyamv yjdyamv commented Mar 11, 2026

Fixes #13127
The previous labels "Chinese (China)" and "Chinese (Taiwan)" could be misinterpreted as political divisions, while the actual difference is the writing script. Changing to "Simplified Chinese" and "Traditional Chinese" is more accurate and inclusive.

Screenshots

2026-03-11_09-09 2026-03-11_09-22

Testing strategy

Try build KeepassXC and see"Chinese (China)/(Taiwan)" becomes to "Simplified/Traditional Chinese" in below.

  • In Help -> About -> Contributors -> Translations
  • Tools -> Settings -> Basic Settings -> User Interface -> Language

Type of change

  • ✅ Bug fix (non-breaking change that fixes an issue)

@phoerious
Copy link
Copy Markdown
Member

phoerious commented Mar 11, 2026

I would prefer Chinese (Simplified) and Chinese (Traditional). That way they both stay together in the selection dropdown.

Besides, the strings are not translatable this way. But it seems that Qt doesn't do that either.

Replace "Chinese (China)" with "Chinese (Simplified)" and "Chinese
(Taiwan)" with "Chinese (Traditional)". This keeps both items adjacent
in the language dropdown, uses script-accurate naming, and avoids any
geographic misinterpretation.
@yjdyamv
Copy link
Copy Markdown
Contributor Author

yjdyamv commented Mar 11, 2026

Thanks for the feedback! I've updated the commit to use Chinese (Simplified) and Chinese (Traditional) as suggested. The two options now appear together in the language dropdown. Please take another look when you have time.

@droidmonkey droidmonkey merged commit 40c79f5 into keepassxreboot:develop Mar 14, 2026
12 checks passed
pull bot pushed a commit to Andyworldclub/keepassxc that referenced this pull request Mar 14, 2026
…assxreboot#13129)

Replace "Chinese (China)" with "Chinese (Simplified)" and "Chinese (Taiwan)" with "Chinese (Traditional)". This keeps both items adjacent in the language dropdown, uses script-accurate naming, and avoids any geographic misinterpretation.
pull bot pushed a commit to byxy77/keepassxc that referenced this pull request Mar 14, 2026
…assxreboot#13129)

Replace "Chinese (China)" with "Chinese (Simplified)" and "Chinese (Taiwan)" with "Chinese (Traditional)". This keeps both items adjacent in the language dropdown, uses script-accurate naming, and avoids any geographic misinterpretation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rename Chinese language items from "Chinese (China)" and "Chinese (Taiwan)" to script-based names

3 participants