Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Prevents the menubar from being hidden on macOS, where the menubar is a system-level element and hiding it causes a "phantom menu" issue (#10706).
Changes:
- Skips setting menubar max height to 0 on macOS in
applySettingsChanges - Short-circuits the Alt-key menubar toggle event filter on macOS
- Hides the "Show Menubar" checkbox in settings on macOS to avoid user confusion
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/gui/MainWindow.cpp | Guards menubar-hiding logic and Alt-key toggle with #ifndef Q_OS_MACOS |
| src/gui/ApplicationSettingsWidget.cpp | Hides the menubar visibility checkbox on macOS |
You can also share your feedback on Copilot code review. Take the survey.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #13147 +/- ##
===========================================
- Coverage 64.60% 64.57% -0.03%
===========================================
Files 378 378
Lines 39911 39913 +2
===========================================
- Hits 25783 25772 -11
- Misses 14128 14141 +13 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
phoerious
approved these changes
Mar 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Testing strategy
Tested on macOS, phantom menu no longer appears even if
HideMenubar=trueis set in the config.Type of change