Skip to content

Prevent hiding menubar on macOS#13147

Merged
droidmonkey merged 1 commit intodevelopfrom
fix/macos-menubar
Mar 14, 2026
Merged

Prevent hiding menubar on macOS#13147
droidmonkey merged 1 commit intodevelopfrom
fix/macos-menubar

Conversation

@droidmonkey
Copy link
Copy Markdown
Member

Testing strategy

Tested on macOS, phantom menu no longer appears even if HideMenubar=true is set in the config.

Type of change

  • ✅ Bug fix (non-breaking change that fixes an issue)

@droidmonkey droidmonkey added this to the v2.8.0 milestone Mar 14, 2026
@droidmonkey droidmonkey requested a review from phoerious March 14, 2026 22:42
Copilot AI review requested due to automatic review settings March 14, 2026 22:42
@droidmonkey droidmonkey added platform: macOS pr: bugfix Pull request fixes a bug labels Mar 14, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Prevents the menubar from being hidden on macOS, where the menubar is a system-level element and hiding it causes a "phantom menu" issue (#10706).

Changes:

  • Skips setting menubar max height to 0 on macOS in applySettingsChanges
  • Short-circuits the Alt-key menubar toggle event filter on macOS
  • Hides the "Show Menubar" checkbox in settings on macOS to avoid user confusion

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
src/gui/MainWindow.cpp Guards menubar-hiding logic and Alt-key toggle with #ifndef Q_OS_MACOS
src/gui/ApplicationSettingsWidget.cpp Hides the menubar visibility checkbox on macOS

You can also share your feedback on Copilot code review. Take the survey.

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 14, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 64.57%. Comparing base (40c79f5) to head (eec73e3).
⚠️ Report is 1 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #13147      +/-   ##
===========================================
- Coverage    64.60%   64.57%   -0.03%     
===========================================
  Files          378      378              
  Lines        39911    39913       +2     
===========================================
- Hits         25783    25772      -11     
- Misses       14128    14141      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@droidmonkey droidmonkey merged commit 38a1119 into develop Mar 14, 2026
16 checks passed
@droidmonkey droidmonkey deleted the fix/macos-menubar branch March 14, 2026 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants