Add more entry types for Proton Pass importer#13148
Merged
droidmonkey merged 1 commit intodevelopfrom Mar 15, 2026
Merged
Conversation
* Fixes #13130 * Add wifi and sshKey import types * Add catch-all import type to prevent loss of data when Proton Pass introduces new things
Contributor
There was a problem hiding this comment.
Pull request overview
Extends the Proton Pass JSON importer (src/format/ProtonPassReader.cpp) to better preserve data for additional Proton Pass entry types and to avoid dropping fields when Proton introduces new/unknown types (issue #13130).
Changes:
- Add explicit import mappings for
wifiandsshKeyentry types. - Add an “unknown type” fallback that copies
contentfields into entry attributes. - Extend Proton Pass import test fixture and assertions to cover unknown-type behavior.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
src/format/ProtonPassReader.cpp |
Adds wifi/sshKey handling and an unknown-type fallback that copies content fields into attributes/notes. |
tests/data/protonpass_export.json |
Adds an unknownType item to the Proton Pass export fixture. |
tests/TestImports.cpp |
Adds assertions for imported attributes from an unknown-type entry. |
You can also share your feedback on Copilot code review. Take the survey.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #13148 +/- ##
===========================================
- Coverage 64.60% 64.60% -0.00%
===========================================
Files 378 378
Lines 39911 39928 +17
===========================================
+ Hits 25783 25792 +9
- Misses 14128 14136 +8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
phoerious
approved these changes
Mar 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes Import from Proton Pass (json) loses data (entries imported with empty fields) #13130
Add wifi and sshKey import types
Add catch-all import type to prevent loss of data when Proton Pass introduces new things
Testing strategy
Added test case
Type of change