Skip to content

Add more entry types for Proton Pass importer#13148

Merged
droidmonkey merged 1 commit intodevelopfrom
fix/protonpass-wifi
Mar 15, 2026
Merged

Add more entry types for Proton Pass importer#13148
droidmonkey merged 1 commit intodevelopfrom
fix/protonpass-wifi

Conversation

@droidmonkey
Copy link
Copy Markdown
Member

Testing strategy

Added test case

Type of change

  • ✅ Bug fix (non-breaking change that fixes an issue)

* Fixes #13130

* Add wifi and sshKey import types
* Add catch-all import type to prevent loss of data when Proton Pass introduces new things
@droidmonkey droidmonkey added this to the v2.8.0 milestone Mar 14, 2026
@droidmonkey droidmonkey requested a review from phoerious March 14, 2026 23:22
@droidmonkey droidmonkey added pr: new feature Pull request adds a new feature import: Proton Pass labels Mar 14, 2026
Copilot AI review requested due to automatic review settings March 14, 2026 23:22
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Extends the Proton Pass JSON importer (src/format/ProtonPassReader.cpp) to better preserve data for additional Proton Pass entry types and to avoid dropping fields when Proton introduces new/unknown types (issue #13130).

Changes:

  • Add explicit import mappings for wifi and sshKey entry types.
  • Add an “unknown type” fallback that copies content fields into entry attributes.
  • Extend Proton Pass import test fixture and assertions to cover unknown-type behavior.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.

File Description
src/format/ProtonPassReader.cpp Adds wifi/sshKey handling and an unknown-type fallback that copies content fields into attributes/notes.
tests/data/protonpass_export.json Adds an unknownType item to the Proton Pass export fixture.
tests/TestImports.cpp Adds assertions for imported attributes from an unknown-type entry.

You can also share your feedback on Copilot code review. Take the survey.

Comment thread src/format/ProtonPassReader.cpp
Comment thread src/format/ProtonPassReader.cpp
Comment thread src/format/ProtonPassReader.cpp
Comment thread tests/TestImports.cpp
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 15, 2026

Codecov Report

❌ Patch coverage is 58.82353% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 64.60%. Comparing base (40c79f5) to head (488dbf5).
⚠️ Report is 2 commits behind head on develop.

Files with missing lines Patch % Lines
src/format/ProtonPassReader.cpp 58.82% 7 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #13148      +/-   ##
===========================================
- Coverage    64.60%   64.60%   -0.00%     
===========================================
  Files          378      378              
  Lines        39911    39928      +17     
===========================================
+ Hits         25783    25792       +9     
- Misses       14128    14136       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@droidmonkey droidmonkey merged commit 379be00 into develop Mar 15, 2026
16 checks passed
@droidmonkey droidmonkey deleted the fix/protonpass-wifi branch March 15, 2026 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

import: Proton Pass pr: new feature Pull request adds a new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Import from Proton Pass (json) loses data (entries imported with empty fields)

3 participants