Skip to content

fix build with botan 3.11#13161

Merged
droidmonkey merged 2 commits intokeepassxreboot:developfrom
Zebra2711:develop
Apr 16, 2026
Merged

fix build with botan 3.11#13161
droidmonkey merged 2 commits intokeepassxreboot:developfrom
Zebra2711:develop

Conversation

@Zebra2711
Copy link
Copy Markdown
Contributor

@Zebra2711 Zebra2711 commented Mar 17, 2026

adding missing <botan/ec_group.h> include for botan 3.11

Fixes #13160

Type of change

  • ✅ Bug fix (non-breaking change that fixes an issue)

@Zebra2711
Copy link
Copy Markdown
Contributor Author

Zebra2711 commented Mar 17, 2026 •
edited
Loading

I don’t know why Archlinux ships botan to extra without rebuilding keepassxc.

$ pactree -rc botan -d 1
botan
├─keepassxc
└─thunderbird

@jketema
Copy link
Copy Markdown

jketema commented Mar 31, 2026 •
edited
Loading

@droidmonkey Any chance this can get merged? We build keepassxc on macOS during some of our internal testing, and that's currently broken due to this.

@juippis juippis mentioned this pull request Apr 4, 2026
Open
Zebra2711 and others added 2 commits April 15, 2026 23:41
@Zebra2711 @droidmonkey
fix build with botan 3.11
e7eec87 
adding missing <botan/ec_group.h> include
@droidmonkey
Fix code format
d0d7457
@droidmonkey droidmonkey merged commit e67cd93 into keepassxreboot:develop Apr 16, 2026
12 checks passed
@droidmonkey
Copy link
Copy Markdown
Member

droidmonkey commented Apr 16, 2026

@jketema sorry for delay, merged

@jketema
Copy link
Copy Markdown

jketema commented Apr 16, 2026

Thank you! 🎉

pull bot pushed a commit to TKaxv-7S/keepassxc that referenced this pull request Apr 16, 2026
@Zebra2711 @droidmonkey @pull
fix build with botan 3.11 (keepassxreboot#13161)
63d26ce 
---------

Co-authored-by: Jonathan White <support@dmapps.us>
pull bot pushed a commit to Andyworldclub/keepassxc that referenced this pull request Apr 16, 2026
@Zebra2711 @droidmonkey @pull
fix build with botan 3.11 (keepassxreboot#13161)
780afad 
---------

Co-authored-by: Jonathan White <support@dmapps.us>
pull bot pushed a commit to byxy77/keepassxc that referenced this pull request Apr 16, 2026
@Zebra2711 @droidmonkey @pull
fix build with botan 3.11 (keepassxreboot#13161)
930876e 
---------

Co-authored-by: Jonathan White <support@dmapps.us>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@droidmonkey droidmonkey droidmonkey approved these changes

Assignees

No one assigned

Labels

build system

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Arch linux / error while loading shared libraries: libbotan-3.so.10: cannot open shared object file: No such file or directory

3 participants

@Zebra2711 @jketema @droidmonkey