Fixed uninitialized variable m_mode in SymmetricCipher.h

[mateea326]

Description

The SymmetricCipher class used a defaulted constructor (= default), which left the m_mode member variable uninitialized. In C++, enum members are not automatically zero-initialized, meaning that if mode() is called before init(), it returns an indeterminate garbage value from the stack.

This issue was identified via static analysis (cppcheck) as an uninitMemberVar warning in the crypto module.

Fix: Replaced the defaulted constructor with an explicit constructor that initializes m_mode to SymmetricCipher::InvalidMode:

explicit SymmetricCipher()
    : m_mode(InvalidMode)
{
}

Impact:

• Security & Stability: Ensures the cryptographic object is in a well-defined state immediately upon construction, before init() is called.
• Logic Integrity: Prevents other components from receiving unpredictable values if they query the cipher's mode prematurely.
• Code Quality: Resolves a static analysis warning in a security-critical area of the codebase.

Screenshots

N/A — header-only change with no visual output.

Testing strategy

Run cppcheck to confirm the warning is resolved:

cppcheck --enable=warning src/crypto/SymmetricCipher.h

The uninitMemberVar warning for m_mode should no longer appear. Existing unit tests for the crypto module continue to pass unchanged.

Type of change

• ✅ Bug fix (non-breaking change that fixes an issue)

[Copilot]

Pull request overview

Fixes an uninitialized member in SymmetricCipher (crypto module) by ensuring m_mode is set to a defined value immediately upon construction, avoiding indeterminate results when mode() is called before init().

Changes:

• Replaced the defaulted constructor with an explicit inline constructor.
• Initialized m_mode to SymmetricCipher::InvalidMode at construction time.

[michaelk83]

You should be able to keep the default constructor by specifying an initializer on the field itself: Mode m_mode{InvalidMode};

[mateea326]

Fixed it and added Mode m_mode{InvalidMode}; as you suggested