Skip to content

chore: standardize golangci-lint v2 setup#138

Merged
tekenstam merged 1 commit intomasterfrom
chore/standardize-golangci-lint
Mar 22, 2026
Merged

chore: standardize golangci-lint v2 setup#138
tekenstam merged 1 commit intomasterfrom
chore/standardize-golangci-lint

Conversation

@tekenstam
Copy link
Copy Markdown
Member

Summary

Closes #137

Standardizes the golangci-lint setup to the keikoproj standard:

  • Add .golangci.yml with golangci-lint v2 config format (exclusion presets for common false positives, generated code, legacy patterns)
  • Pin golangci-lint from latestv2.11.4 in lint.yml for reproducible CI
  • Bump GOLANGCI_LINT_VERSION in Makefile from v2.1.1v2.11.4 to keep in sync

Gosec security scan and license check jobs are unchanged.

Test plan

  • Verify the golangci-lint CI check passes on this PR
  • Confirm gosec and license check jobs continue to pass

🤖 Generated with Claude Code

Keep Makefile GOLANGCI_LINT_VERSION in sync with the CI workflow.

Signed-off-by: Todd Ekenstam <todd_ekenstam@intuit.com>
@tekenstam tekenstam requested review from a team as code owners March 22, 2026 19:14
@tekenstam tekenstam merged commit 7b9c7b7 into master Mar 22, 2026
5 checks passed
@tekenstam tekenstam deleted the chore/standardize-golangci-lint branch March 22, 2026 19:28
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 58.37%. Comparing base (1655722) to head (817395d).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #138   +/-   ##
=======================================
  Coverage   58.37%   58.37%           
=======================================
  Files          12       12           
  Lines         603      603           
=======================================
  Hits          352      352           
  Misses        232      232           
  Partials       19       19           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

chore: standardize golangci-lint v2 setup

2 participants