MESH-7783 Improve unit test coverage#28
Merged
vrushalijoshi merged 2 commits intokeikoproj:masterfrom Sep 19, 2025
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #28 +/- ##
===========================================
+ Coverage 36.58% 60.53% +23.95%
===========================================
Files 18 18
Lines 1077 1077
===========================================
+ Hits 394 652 +258
+ Misses 653 392 -261
- Partials 30 33 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: lszabo <levi_szabo@intuit.com>
shriramsharma
approved these changes
Sep 19, 2025
vrushalijoshi
approved these changes
Sep 19, 2025
Collaborator
vrushalijoshi
left a comment
vrushalijoshi
left a comment
There was a problem hiding this comment.
overall looks good
| @@ -1,137 +0,0 @@ | |||
| package Reconciler | |||
Collaborator
There was a problem hiding this comment.
Any reason we are removing this test?
Contributor
Author
There was a problem hiding this comment.
You're right, I may have accidentally deleted it from the editor. I restored it, will take a minute to compile.
Signed-off-by: lszabo <levi_szabo@intuit.com>
shriramsharma
approved these changes
Sep 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.