Open
Conversation
Remove keikoproj/aws-sdk-go-cache from instance-manager as part of the AWS SDK v1 deprecation effort. The library provided response caching for AWS SDK v1 sessions to mitigate rate limiting, but this is no longer needed: - AWS SDK v1 is EOL with no v2 equivalent for the cache library - AWS SDK v2's built-in adaptive retry/token-bucket rate limiting covers the same concern - Rate limiting has not been a practical issue in production Changes: - Remove cacheCfg parameter from all five GetAws*Client constructors - Remove cache.AddCaching, SetCacheTTL, and SetExcludeFlushing calls - Remove cache-hit logging handlers from all client constructors - Remove all TTL constants and cache config constants from aws.go - Remove cacheCollector Prometheus registration from main.go - Run go mod tidy to drop aws-sdk-go-cache, ccache/v2, and golang/glog The existing RetryLogger with throttle metrics and custom backoff delays is preserved unchanged. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Todd Ekenstam <todd_ekenstam@intuit.com>
tekenstam
force-pushed
the
deps/remove-aws-sdk-go-cache
branch
from
8ed2476 to
dba766d
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #526 +/- ##
==========================================
+ Coverage 46.89% 47.76% +0.86%
==========================================
Files 40 40
Lines 5879 5816 -63
==========================================
+ Hits 2757 2778 +21
+ Misses 2964 2878 -86
- Partials 158 160 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Add coverage for NewRetryLogger and RetryRules to verify the retry mechanism works correctly now that aws-sdk-go-cache has been removed and RetryLogger is the sole rate-limit resilience layer. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Todd Ekenstam <todd_ekenstam@intuit.com>
Brings in Go 1.26, K8s 1.33 client-go, and keikoproj libs updates from master (#521). Resolved go.mod/go.sum conflicts by applying master's dependency updates while keeping aws-sdk-go-cache removed (the purpose of this PR). Signed-off-by: Todd Ekenstam <todd_ekenstam@intuit.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
keikoproj/aws-sdk-go-cachefrom instance-manager as part of the AWS SDK v1 deprecation effort (closes chore: deprecate and remove aws-sdk-go-cache dependency #525)cacheCfgparameter from all fiveGetAws*Clientconstructors and removes allcache.AddCaching,SetCacheTTL, andSetExcludeFlushingcallsaws.go, and removescacheCollectorPrometheus registration frommain.gogo mod tidyto dropaws-sdk-go-cache,karlseguin/ccache/v2, andgolang/glogThe existing
RetryLoggerwith throttle metrics and custom backoff delays is preserved unchanged. AWS SDK v1's built-in retry logic handles rate limiting without the cache layer.Test plan
go build ./...passesgo test ./...passes (all existing tests green)go vet ./...passesaws-sdk-go-cacheimports remain in source files🤖 Generated with Claude Code