Skip to content

Reimplement retry-interval when draining nodes#188

Open
omgrr wants to merge 2 commits intokeikoproj:masterfrom
omgrr:add-retry-interval
Open

Reimplement retry-interval when draining nodes#188
omgrr wants to merge 2 commits intokeikoproj:masterfrom
omgrr:add-retry-interval

Conversation

@omgrr
Copy link

@omgrr omgrr commented Jan 12, 2024

This addresses #185 by re-adding the retryInterval when draining.

This also re-adds the retry-go package in order to do both the retry and the delay functionality. If there was another reason for removing it let me know!

Testing this on an actual cluster with setting the drain-interval to 30 seconds and the drain-timeout to 120 seconds I can see from the logs that there is the correct amount of time between retries.

time="2024-01-12T19:32:06Z" level=info msg="retrying drain, node <node name>"
time="2024-01-12T19:34:36Z" level=info msg="retrying drain, node <node name>"
# 2 minutes 30 seconds between retries

omgrr and others added 2 commits January 12, 2024 16:06
Co-authored-by: Jerome Wisniewski <jwisniewski@paypal.com>
@2rs2ts
Copy link
Contributor

2rs2ts commented Jul 3, 2025

I'd love to have this feature. I see the PR has been waiting for approval for a year and a half... I know there are PR conflicts, but once they're resolved, I wonder how to get people to take a look at it.

@tekenstam – sorry to bother you with a ping, but I noticed you have merged most recent commits to this repo. Are you in charge of it at the moment? Does @omgrr's change look good? I'd even be willing to try to handle a rebase myself if necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants