Reimplement retry-interval when draining nodes#188
Open
omgrr wants to merge 2 commits intokeikoproj:masterfrom
Open
Reimplement retry-interval when draining nodes#188omgrr wants to merge 2 commits intokeikoproj:masterfrom
omgrr wants to merge 2 commits intokeikoproj:masterfrom
Conversation
Co-authored-by: Jerome Wisniewski <jwisniewski@paypal.com>
Contributor
|
I'd love to have this feature. I see the PR has been waiting for approval for a year and a half... I know there are PR conflicts, but once they're resolved, I wonder how to get people to take a look at it. @tekenstam – sorry to bother you with a ping, but I noticed you have merged most recent commits to this repo. Are you in charge of it at the moment? Does @omgrr's change look good? I'd even be willing to try to handle a rebase myself if necessary. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses #185 by re-adding the
retryIntervalwhen draining.This also re-adds the
retry-gopackage in order to do both the retry and the delay functionality. If there was another reason for removing it let me know!Testing this on an actual cluster with setting the drain-interval to 30 seconds and the drain-timeout to 120 seconds I can see from the logs that there is the correct amount of time between retries.