chore: remove aws-sdk-go-cache dependency#272
Draft
tekenstam wants to merge 2 commits into
Draft
Conversation
Remove the keikoproj/aws-sdk-go-cache library which is built on AWS SDK for Go v1 (EOL July 2025). AWS API rate limiting has not been an issue in practice, and the standard SDK retry mode handles throttling without explicit response caching. - Remove cache import and config from cmd/common.go, cmd/serve.go - Simplify newELBv2Client/newELBClient to drop cacheCfg parameter - Remove CacheConfig field from pkg/service/manager.ManagerContext - Remove NodeAgeCacheTTL constant and cache-flush block from server.go - Remove NodeAgeCacheTTL override from server_test.go - Run go mod tidy to drop keikoproj/aws-sdk-go-cache from go.mod/go.sum Closes #271 Signed-off-by: Todd Ekenstam <todd_ekenstam@intuit.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #272 +/- ##
==========================================
+ Coverage 64.94% 65.07% +0.13%
==========================================
Files 15 15
Lines 1181 1174 -7
==========================================
- Hits 767 764 -3
+ Misses 339 336 -3
+ Partials 75 74 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove the
keikoproj/aws-sdk-go-cachelibrary which is built on AWS SDK for Go v1 (EOL July 2025). AWS API rate limiting has not been an issue in practice, and the standard SDK retry mode (token-bucket + exponential backoff) handles throttling without explicit response caching.Changes
NewCacheConfigusage fromcmd/common.go,cmd/serve.gonewELBv2Client/newELBClientto dropcacheCfgparameterCacheConfigfield frompkg/service/manager.ManagerContextNodeAgeCacheTTLconstant and cache-flush block frompkg/service/server.goNodeAgeCacheTTLoverride frompkg/service/server_test.gogo mod tidyto dropkeikoproj/aws-sdk-go-cachefromgo.mod/go.sumCloses #271
Test plan
go build ./...passesgo test ./...passes (pre-existingTest_Metricsfailure unrelated to this change)aws-sdk-go-cache,CacheConfig,cacheCfg, orNodeAgeCacheTTL🤖 Generated with Claude Code