Remove keikoproj/aws-sdk-go-cache dependency#550
Draft
Conversation
The aws-sdk-go-cache library depends on AWS SDK Go v1 which reaches end-of-life in July 2025. The cache provides minimal value (60s TTLs on DescribeAutoScalingGroups and DescribeLaunchTemplates only), and the AWS SDK's built-in retry mechanism with exponential backoff adequately handles throttling without custom caching. Closes #544 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Todd Ekenstam <todd_ekenstam@intuit.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
github.com/keikoproj/aws-sdk-go-cachedependency, which relies on AWS SDK Go v1 (EOL July 2025)CacheConfigfield fromRollingUpgradeReconcilerand all associated cache setup/flush logicgithub.com/karlseguin/ccache/v2dependencyThe cache provided minimal value — only 60s TTLs on
DescribeAutoScalingGroupsandDescribeLaunchTemplates. AWS SDK v1's built-in retry mechanism with exponential backoff handles throttling without custom caching.Closes #544
Test plan
go build ./...passes (verified locally)go test ./...passes