Support metaarg expansion#151
Open
jedinym wants to merge 2 commits intokeilerkonzept:masterfrom
Open
Conversation
To support the use case where the Dockerfile uses a nested argument in an image base name, we need to expand meta arguments with already defined arguments. Signed-off-by: Martin Jediny <jedinym@proton.me>
Changed the example Dockerfile.3 to contain nested arguments, to showcase that dockerfile-json will expand arguments with previous arguments. Signed-off-by: Martin Jediny <jedinym@proton.me>
|
@sgreben could you please take a look here? |
Author
|
@sgreben have you had the chance to take a look at this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for metaarg expansion if an argument is nested.
Example Dockerfile:
The
masterversion does not support argument nesting like that, resulting in unexpanded variables. Comparing themasterversion with this branch shows the difference:Attaching full outputs of
masterbranch and this branch below.actual.json
expected.json