i18n: complete Korean (ko) translations#385
Open
moduvoice wants to merge 1 commit into
Open
Conversation
messages/ko.json was missing 277 of 746 keys (Admin panel, User
profile admin/user views, Agent, Auth sign-up, Layout, MCP, and
Workflow strings). Translated all missing keys into natural Korean,
matching the existing file's tone and terminology, and removed one
stale key no longer present in messages/en.json. Verified 1:1 key
parity with en.json and preserved all {placeholder} interpolation
tokens.
|
@moduvoice is attempting to deploy a commit to the cgoinglove's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This completes Korean (
ko) translation coverage — to help Korean-speaking users use thisopen-source project more comfortably in their own language.
kowas already registered inSUPPORTED_LOCALESand wired into the i18n loader, butmessages/ko.jsonwas missing alarge portion of keys (they were silently falling back to English via the deep-merge
fallback in
src/i18n/request.ts).한국 사람들의 오픈소스 이용에 도움이 되게 하기 위해서 한글화 작업을 완료하였습니다.
Changes
messages/ko.json: translated all 277 keys that existed inmessages/en.jsonbut weremissing from
ko.json— primarily the Admin panel (Admin.*), the admin/self views ofthe user profile (
User.Profile.admin.*,User.Profile.user.*,User.Profile.common.*),Agent.*,Auth.SignUp.*,Layout.*,MCP.*, andWorkflow.*sections.Chat.Tool.toolModeDescription, that existed in the oldko.jsonbut no longer exists inen.json(it has been superseded by the threeseparate
autoToolModeDescription/manualToolModeDescription/noneToolModeDescriptionkeys, which were already translated).kowas already presentin
SUPPORTED_LOCALES(src/lib/const.ts) and the dynamic-import + deep-merge fallbackin
src/i18n/request.tsneeded no changes.Testing
en.jsonandko.jsonto their leaf keys and diffedthem — confirmed 746/746 keys present, 0 missing, 0 extra.
{token}interpolation placeholder from eachstring and compared EN vs KO per key — all genuine variables (
{name},{role},{count},{tokens},{period}, etc.) are preserved. The only two "mismatches" a naivecheck flags come from the literal
sinside the English ICU plural macro(
model{count, plural, =1 {} other {s}}) intokensAcrossandtotalCount— the Koreanstrings correctly collapse the plural macro into a single natural string since Korean
nouns don't inflect for plural count. Verified this is valid by instantiating both
translated strings with
intl-messageformat(the library behindnext-intl) atcount=1andcount>1— both parse and format correctly with no runtime errors.pnpm exec biome format messages/ko.jsonandpnpm exec biome lint messages/ko.json(both clean, no changes needed) andpnpm check-types(tsc --noEmit, passes with no errors).en.json,including the entire previously-missing Admin panel and
User.Profile.admin/usersubtrees, checking for mistranslation, register, and terminology consistency with the
pre-existing 470 keys (e.g. 에이전트=Agent, 워크플로우=Workflow, MCP 서버, 역할=role,
정지/정지 해제=ban/unban) — all consistent with established usage already present in the
file before this change.