Add rudimentary read support for Data General "2F" format#528
Closed
pkooiman wants to merge 2 commits into
Closed
Conversation
Owner
|
Oh that's pretty good. Is the MFM mode also valid, or just copied over from existing code but defunct here? |
Owner
|
Ohhhh this is probably FM only and worked out from the doc and flux file linked in ticket #526? Nice job if so, I can put together Data General 2F support from the same resources plus your code, which probably only needs some cleanup and redundant code deleted. |
Author
|
Correct, FM only and put together from the flux file and the docs. I only worked on reading, the writing code is still a 1:1 copy from Northstar ;.) |
Owner
|
Aha! Okay, I will take all the available info and cook up something from your prototype. Thanks. |
c6e4897 to
5cc6fb0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#526 I managed to get conversion from flux image working. Unfortunately I don't understand Greaseweazle internals well enough to create a complete (and sane) implementation but in case it is helpful, here is my attempt.