Skip to content

Fix for issue #549#550

Closed
UnionSystems wants to merge 1 commit into
keirf:masterfrom
UnionSystems:patch-1
Closed

Fix for issue #549#550
UnionSystems wants to merge 1 commit into
keirf:masterfrom
UnionSystems:patch-1

Conversation

@UnionSystems
Copy link
Copy Markdown
Contributor

This pull request fixes an issue with evaluation of usb ports. When a port name is empty, gw.exe crashes when accessing
properties of a 'NoneType' object.

@keirf
Copy link
Copy Markdown
Owner

keirf commented Apr 29, 2025

Looks good. I have forwarded this upstream (pyserial/pyserial#725) so let's see what they say. Preferably I will take this from the upstream PR, but failing that I will commit your fix directly for the next tools release. Thanks!

@keirf
Copy link
Copy Markdown
Owner

keirf commented Apr 30, 2025

Re-snapshotted the fixed upstream file.

@keirf keirf closed this Apr 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants