Add proper support for Sharp 2HS images#635
Open
UNDEF2 wants to merge 1 commit into
Open
Conversation
Author
|
Any movement on this? I'd like to get this merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support was previously added (in #245) for 9-sector images on X68K and PC-98, but the Sharp variant is actually a little different; sector numbering starts from 10, except for the first sector of side 0, track 0, where r=1 in order to allow the boot ROM to find the IPL. Unfortunately, most images in this format are either DIM or a raw sector image, neither of which encode the sector numbers. This change adds a new variant of the 2HS format to accomplish this, and detects it in the DIM loader by looking for a 9SCFMT IPL header. The most invasive change is a new argument in ibm.py that allows for passing a list of sector numbers so that we can deal with the discontinuity on track 0.0.