Skip to content

Redirect to s3 headers #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
avdata99 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Redirect to s3 headers #16

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b5f26d0
Clean Redirect headers
avdata99 Feb 1, 2023
bf9cc2c
Fix ret value
avdata99 Feb 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion ckanext/s3filestore/views/resource.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,15 @@ def resource_download(package_type, id, resource_id, filename=None):
'attachment; filename=' + filename,
}
url = upload.get_signed_url_to_key(key_path, params)
return redirect(url)

redir = redirect(url)
# remove Authorization header from redirect
# so that it doesn't get passed to S3
# (which doesn't like it)
redir.headers.pop('Authorization', None)
# remove Origin header because it causes problems with CORS on S3
redir.headers.pop('Origin', None)
return redir

except ClientError as ex:
if ex.response['Error']['Code'] in ['NoSuchKey', '404']:
Expand Down