fix: remove incorrect warn about icon 1024x1024 size#3
Merged
Conversation
Contributor
|
Released as v1.2.1 and published to npm. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the minimum and recommended requirements for icon images in the TvOS asset processing tool. The changes remove the recommended icon size threshold (1280x1280), making 1024x1024 both the minimum and sufficient size for all outputs. Related warnings and tests for the recommended icon size have also been removed for consistency.
Icon size requirement updates:
README.md; 1024x1024 is now considered sufficient for all outputs.ICON_RECOMMENDEDconstant has been removed fromsrc/config.ts, and all references to a recommended icon size have been deleted.Validation logic and test updates:
src/config.ts.tests/config.test.ts.createTestIconintests/fixtures/create-fixtures.tshas been updated to remove reference to the recommended minimum.