Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add missing dev dependencies: prebuildify and python package distutils in CI #1050

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fix: Add missing dev dependencies: prebuildify and python package distutils in CI #1050

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4a09c36
Update package lock file to fix vulnerabilities reported by npm audit
simonmysun Sep 25, 2024
2ca52b6
Add prebuildify and node-gyp to dev dependencies
simonmysun Sep 25, 2024
e951e34
Add python package distutils with system package manager
simonmysun Sep 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,17 +31,17 @@ RUN echo "#log: ${project}: Setup system" \
&& apt-get install -y \
build-essential \
python3 \
python3-distutils \
&& apt-get clean \
&& update-alternatives --install /usr/local/bin/python python /usr/bin/python3 20 \
&& npm i -g prebuildify@5 node-gyp@9 \
&& sync

ADD . /usr/local/opt/${project}
WORKDIR /usr/local/opt/${project}

RUN echo "#log: ${project}: Running build" \
&& set -x \
&& npm ci \
&& npm ci --include=dev \
&& npm run build

ARG RUN_TESTS=true
Expand Down
5 changes: 2 additions & 3 deletions Dockerfile-alpine
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,16 +16,15 @@ ENV LANG ${LC_ALL}

RUN echo "#log: ${project}: Setup system" \
&& set -x \
&& apk add --update build-base python3 \
&& npm i -g prebuildify@5 node-gyp@9 \
&& apk add --update build-base python3 py3-setuptools \
&& sync

ADD . /usr/local/opt/${project}
WORKDIR /usr/local/opt/${project}

RUN echo "#log: ${project}: Running build" \
&& set -x \
&& npm ci \
&& npm ci --include=dev \
&& npm run build

ARG RUN_TESTS=true
Expand Down
4 changes: 2 additions & 2 deletions build-all.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,8 @@ if [ -n "$CLEAN" ]; then
rm -rf prebuilds
fi

npm i -g prebuildify@5 node-gyp@9
npm ci
npm install --include=dev
npm ci --include=dev
#npm run build

for PLATFORM in linux/amd64 linux/arm64/v8 linux/arm/v7; do
Expand Down
Loading