Add Confluence Cloud support (v2.0.0)#35
Merged
Merged
Conversation
- CloudConfluenceClient: v2 API for page get/update; inherited v1 endpoint for attachment upload (v2 has none). Auto-detected from *.atlassian.net hostnames; instance_type config field overrides for custom domains. - Cloud auth: CONFLUENCE_EMAIL + CONFLUENCE_TOKEN (API token) basic auth, not gated behind --unsafe-auth. /wiki is appended to bare site URLs and written back to config so attachment URL matching keeps working. - Attachment content reads use the REST download endpoint on Cloud; the legacy /download/attachments path 401s for API-token auth there. - Credentials may come from the environment without a .csync.env file; csync injects FIFO-served env files (e.g. 1Password) via --env-file since Docker VM file sharing cannot pass host FIFOs. - Portable BSD/GNU sed in the release Makefile. - README/CLAUDE.md/examples updated; note on IPv6-related image build failures and the Docker Desktop IPv4-only fix.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds Atlassian Cloud support alongside the existing Data Center support, released as v2.0.0.
CloudConfluenceClient: v2 API (/api/v2/pages/{id}) for page get/update; inherits the v1 attachment upload endpoint (v2 has none). Selected automatically for*.atlassian.nethostnames;instance_type: cloud | datacenterconfig field overrides for custom domains.CONFLUENCE_EMAIL+CONFLUENCE_TOKEN(Atlassian API token) via basic auth — not gated behind--unsafe-auth, which remains DC-password-only. A bare site URL gets/wikiappended and written back to the config so attachment download-URL construction and prefix matching keep working..../child/attachment/{id}/download); the legacy/download/attachments/path returns 401 for API-token auth there. Fixes mermaid source restoration on pull..csync.envfile; thecsyncwrapper detects a FIFO env file (e.g. a 1Password-served environment) and injects it via--env-fileprocess substitution, since Docker Desktop's VM file sharing cannot pass host FIFOs.sed -i.bakworks on BSD and GNU sed).Smoke-tested end to end against a live Cloud site: pull, push, round-trip stability, conflict detection, attachment upload, and mermaid render + source restore. 197 tests, 100% coverage maintained. DC client code path is unchanged.