Skip to content

feat(docker): Add option to run via Docker Compose #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

feat(docker): Add option to run via Docker Compose #40

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
789b920
feat(docker): add Dockerfile and Compose spec
julian45 Jun 14, 2024
eab1fd4
build(docker): specify deno container tag
julian45 Jun 22, 2024
82ae57c
refactor(docker): remove redundant suffix
julian45 Jun 22, 2024
e8ec58e
build(docker): run deno as non-root user
julian45 Jun 22, 2024
2939572
Merge branch 'main' into docker-compose
julian45 Jun 23, 2024
1b3f49a
Merge branch 'main' into docker-compose
julian45 Jun 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
FROM denoland/deno

EXPOSE 8000

WORKDIR /app

ADD . /app
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A .dockerignore file should probably be added (with the same or similar entries as .gitignore) so that this doesn't copy unwanted stuff.


RUN deno cache server/main.ts

ARG version
ENV DENO_DEPLOYMENT_ID $version
CMD deno run -A server/main.ts
10 changes: 10 additions & 0 deletions docker-compose.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
services:
web:
build:
context: .
args:
version: v2024.6.12
container_name: harmony-container
image: harmony
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tagging the image with $DENO_DEPLOYMENT_ID might make sense? (I don't have much Deno experience, so not sure if this variable is ideal for versioning.)

Suggested change
image: harmony
image: harmony:$DENO_DEPLOYMENT_ID

ports:
- "8000:8000"