Add ETag support for GET /transactions and GET /payment-requests - #1010
Open
joel-metal wants to merge 1 commit into
Open
Add ETag support for GET /transactions and GET /payment-requests#1010joel-metal wants to merge 1 commit into
joel-metal wants to merge 1 commit into
Conversation
…requests Hashes the serialized response and returns it as an ETag header. When the request's If-None-Match already matches, responds 304 Not Modified with an empty body instead of the full payload, cutting bandwidth for polling frontends. Closes kellymusk#904 Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0176gtGcUc8tMZmF8aZysxmD
|
@joel-metal Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
etag::conditional_jsonhelper that serializes a response, hashes it (SHA-256) to produce anETag, and compares against the request'sIf-None-Matchheader.GET /transactionsandGET /payment-requestsnow return thatETagheader on200, and respond304 Not Modifiedwith an empty body when the client'sIf-None-Matchalready matches — cutting bandwidth for polling frontends.API.mdandopenapi.yaml.Closes #904
Test plan
GET /transactionstwice, second call withIf-None-Matchset to the first response'sETag→ expect304GET /payment-requestsETagand a200with body🤖 Generated with Claude Code
https://claude.ai/code/session_0176gtGcUc8tMZmF8aZysxmD