Minor fixes (broken links, typo, unnecessary sed command)#869
Open
onprema wants to merge 6 commits intokelseyhightower:masterfrom
Open
Minor fixes (broken links, typo, unnecessary sed command)#869onprema wants to merge 6 commits intokelseyhightower:masterfrom
sed command)#869onprema wants to merge 6 commits intokelseyhightower:masterfrom
Conversation
jeffawang
reviewed
Jul 5, 2025
|
|
||
| sed "s|SUBNET|$SUBNET|g" \ | ||
| configs/kubelet-config.yaml > kubelet-config.yaml | ||
|
|
||
| scp 10-bridge.conf kubelet-config.yaml \ |
There was a problem hiding this comment.
Small bug: the scp line refers to kubelet-config.yaml, which wouldn't exist without the sed command.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for the excellent tutorial. As I was going through it again, I noticed a few minor things that should be cleaned up. The
sedcommand removal is part of #868, too.