Fix: Remove unnecessary sed command for kubelet-config.yaml in worker…#896
Open
ketanjani21 wants to merge 1 commit intokelseyhightower:masterfrom
Open
Fix: Remove unnecessary sed command for kubelet-config.yaml in worker…#896ketanjani21 wants to merge 1 commit intokelseyhightower:masterfrom
ketanjani21 wants to merge 1 commit intokelseyhightower:masterfrom
Conversation
|
Yeah, noticed it too 👍 |
FallenVEye
reviewed
Aug 15, 2025
| configs/kubelet-config.yaml > kubelet-config.yaml | ||
|
|
||
| scp 10-bridge.conf kubelet-config.yaml \ | ||
| scp 10-bridge.conf configs/kubelet-config.yaml \ |
There was a problem hiding this comment.
You can actually remove configs/kubelet-config.yaml from here, and put it in the next block, where the rest of configs are copied to nodes
Author
There was a problem hiding this comment.
Thank you for the suggestion, updated the PR.
… node bootstrap move kubelet-config.yaml copy with rest of the file copies Signed-off-by: Ketankumar Jani <ketanjani21@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… node bootstrap
Changelog
sedcommand indocs/09-bootstrapping-kubernetes-workers.mdthat attempted to replace "SUBNET" inconfigs/kubelet-config.yamlscpcommand to copy the originalconfigs/kubelet-config.yamlfile directly without modification