add '?' to nullable method parameters#229
Merged
kelvinmo merged 4 commits intokelvinmo:masterfrom Aug 1, 2025
Merged
Conversation
Contributor
Author
|
cc: @kelvinmo |
Contributor
Author
|
I just noticed the CI has the matrix for different PHP versions. Let me add 8.4 to the matrix. |
Owner
|
Please update line 54 of |
Contributor
Author
|
thank you for the feedback! I fixed them |
Owner
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
kelvinmo
added a commit
that referenced
this pull request
Aug 2, 2025
[1.0] Add '?' to nullable method parameters (#229)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: #228
From PHP8.4, a parameter that has null as a default value has to be typed as a nullable type: https://www.php.net/manual/en/migration84.deprecated.php
This PR adds
?to the method parameters that takenullas a default value.