Popup layout and styling enhancements#415
Open
hazzuk wants to merge 12 commits into
Open
Conversation
General visual improvements alongside change to bottom buttons placement.
The news-close icon will now only be visible when an announcement is shown.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR makes changes to the popup window by changing the placement of UI elements and improving the overall look and feel through styling.
Motivation
The previous interface (whilst perfectly functional) suffers from some key issues I set out to solve:
Changes
Testing
My tests included some of the following:
Screenshots
Popup
New (with announcement hidden)
Popup
New/previous
Separate window (dark mode)
New/previous
Separate window (light mode)
New/previous