feat(frontend): collapse Calls detail in analysis - #1226
Merged
Conversation
roborev: Combined Review (
|
The session analysis Calls visualization can consume most of the sidebar, but its summary remains useful when the row detail is not needed. Record the approved disclosure behavior, accessibility contract, and global persistence semantics before implementation so the compact interaction stays consistent with the existing product UI.
The approved analysis-sidebar interaction touches persisted UI state, rendered disclosure behavior, and an existing E2E selector. Capture the test-first sequence and validation boundary before code changes so the preference remains global, accessible, and compatible with the current sidebar tests.
Long sessions can make the Calls visualization consume most of the analysis sidebar even when the aggregate count is enough. Make the compact section header a keyboard-accessible disclosure and preserve the user's choice globally so switching sessions or reloading does not repeatedly reopen unwanted detail. Existing users retain the current expanded default until they choose otherwise.
Main made the session prop on SessionVitals required (#1240); the rebased collapse test now passes session: undefined like the other tests in the file.
mjacobs
force-pushed
the
feat/collapsible-calls-detail
branch
from
July 24, 2026 00:21
799e093 to
e9a8360
Compare
roborev: Combined Review (
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Long session call timelines can consume most of the analysis sidebar even when the aggregate count is all the user needs. The Calls header is now a keyboard-accessible disclosure that keeps the localized summary visible while hiding the time axis and individual rows.
The expanded choice is stored globally in LocalStorage, so switching sessions or reloading preserves the user’s preferred density. Existing users retain the current expanded behavior until they collapse it, and the other analysis sections remain unchanged.
generated by a clanker