Skip to content

feat(recall): add session evidence panel - #1240

Merged
wesm merged 2 commits into
mainfrom
feat/session-recall-panel
Jul 23, 2026
Merged

feat(recall): add session evidence panel#1240
wesm merged 2 commits into
mainfrom
feat/session-recall-panel

Conversation

@wesm

@wesm wesm commented Jul 23, 2026

Copy link
Copy Markdown
Member

Adds a read-only Recall panel to the session analysis view. It lists accepted distilled entries with their type, title, body, extraction generation, and review state.

Valid evidence ranges use the existing transcript navigation path, so reviewers can jump directly from an entry to its source messages. Entries with revoked provenance remain visible for diagnosis but are explicitly labeled and their stale evidence ranges are non-interactive. Session-scoped loading is abort-safe, bounded to 500 entries, and localized across the supported catalogs.

Distilled entries need an inspectable session-local surface so extraction regressions can be noticed without leaving the transcript. Keep review read-only and route evidence through the existing ordinal navigation path.
@roborev-ci

roborev-ci Bot commented Jul 23, 2026

Copy link
Copy Markdown

roborev: Combined Review (86ff51c)

Medium-severity issue found: revoked recall provenance is presented as valid evidence.

Medium

  • frontend/src/lib/components/content/RecallPanel.svelte:77 — Entries with revoked provenance (provenance_ok: false) are displayed identically to valid recall, including clickable evidence links. Because the default API query returns accepted entries regardless of provenance, stale transcript ranges can appear to support recalled information.
    • Fix: Filter invalid entries or clearly label them as provenance-revoked and disable their evidence actions. Add coverage for revoked provenance.

Reviewers: 2 done | Synthesis: codex, 7s | Total: 3m7s

A revoked provenance range no longer substantiates its Recall entry and must not look actionable. Keep the entry visible for extraction review, but identify the revocation and prevent stale transcript navigation.
@roborev-ci

roborev-ci Bot commented Jul 23, 2026

Copy link
Copy Markdown

roborev: Combined Review (f220c45)

Summary: The new recall panel uses existing authentication, safely encodes query parameters, and renders recall content through Svelte’s escaped interpolation. No concrete exploit path or weakened security boundary was identified.

No issues found.


Reviewers: 2 total (1 done, 1 failed) | Synthesis: codex | Total: 38s

@wesm
wesm merged commit 34d326c into main Jul 23, 2026
21 of 22 checks passed
@wesm
wesm deleted the feat/session-recall-panel branch July 23, 2026 13:26
mjacobs added a commit that referenced this pull request Jul 24, 2026
Main made the session prop on SessionVitals required (#1240); the
rebased collapse test now passes session: undefined like the other
tests in the file.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant