Skip to content

Fix browser-timezone session date filters - #1245

Merged
mjacobs merged 3 commits into
kenn-io:mainfrom
gtkacz:1232-browser_timezone
Jul 24, 2026
Merged

Fix browser-timezone session date filters#1245
mjacobs merged 3 commits into
kenn-io:mainfrom
gtkacz:1232-browser_timezone

Conversation

@gtkacz

@gtkacz gtkacz commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

Session list and sidebar calendar-date filters now accept the browser IANA timezone, default omitted values to UTC, and reject invalid zones.

Local calendar dates are translated into DST-aware UTC boundaries while preserving latest-message activity fallback and equivalent SQLite, PostgreSQL, and DuckDB query behavior. The sidebar sends the browser timezone on initial and paginated requests, and the generated API client reflects the new parameter.

Fixes #1232.

@roborev-ci

roborev-ci Bot commented Jul 23, 2026

Copy link
Copy Markdown

roborev: Combined Review (4ef2093)

Verdict: One medium-severity cursor consistency issue must be fixed.

Medium

  • internal/db/session_export.go:125Timezone is omitted from sessionExportCursorFilters and its conversion functions. Resuming with UseCursorFilter silently falls back to UTC, and timezone changes between pages are not detected as filter conflicts, potentially causing missing or duplicate export rows.

    Fix: Add Timezone to the cursor payload, canonicalization, and both filter conversion paths. Add tests covering cursor resume and timezone changes.


Reviewers: 2 done | Synthesis: codex, 10s | Total: 7m13s

@roborev-ci

roborev-ci Bot commented Jul 24, 2026

Copy link
Copy Markdown

roborev: Combined Review (9032e2b)

No issues found.


Reviewers: 2 done | Synthesis: codex | Total: 7m14s

@mjacobs
mjacobs merged commit dc7d627 into kenn-io:main Jul 24, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

[pg serve] Session date filters should use browser timezone instead of UTC

2 participants