feat(parser): detect opencode bash tool failures from metadata.exit

[ajinkyajacob]

Problem

OpenCode bash tool failures leave metadata.exit > 0 in the tool state but the output text does NOT contain the exit status N pattern that AgentsView's isBashFailure() checks. This is not Windows-specific: on a Linux opencode.db, all 24 bash parts with a non-zero exit (1, 127, 128) had output text with no exit status marker, while all 81 successful parts recorded exit=0. Example outputs from real sessions:

• 'choco' is not recognized as an internal or external command - exit=1, no "exit status" text
• (empty output) - exit=1, no text at all
• rsync error: some files could not be transferred - exit=1

The exit code is reliably recorded in metadata.exit by the agent, but the parser never reads it.

Impact

On a Windows machine with 273 opencode sessions, 1233 bash tool failures are missed because they lack the exit status output pattern. Only 51 are currently detected (via the tool:"invalid" fix). The remaining ~1200 are invisible to signals, insights, and health scoring.

Fix

In extractOpenCodeToolCall(), after parsing the tool state, check metadata.exit:

if len(state.Metadata) > 0 {
    var m struct { Exit int `json:"exit"` }
    if err := json.Unmarshal(state.Metadata, &m); err == nil && m.Exit > 0 {
        isFailure = true
    }
}

This is opt-in per agent - only opencode records metadata.exit. Other agents are unaffected.

dataVersion moves to 73 so existing opencode rows are re-parsed and historical sessions backfill the failure events, and the format evidence is recorded in docs/internal/session-format-sources.md.

Branch

https://github.com/ajinkyajacob/agentsview/tree/feat/opencode-metadata-exit-failure-detection

Risk

• Non-zero exit doesn't always mean failure (e.g., grep returns 1 for no match). However, AgentsView's existing exitStatusRe already makes the same assumption via output text. This just adds parity for the metadata path.
• Only applies when metadata key exists in the tool state (opencode format), so other agents are isolated.

[roborev-ci]

roborev: Combined Review (69274d4)

Verdict: One medium-severity issue must be addressed before merging.

Medium

• internal/db/db.go:324 — The parser now persists new tool-result events, but dataVersion remains 71. Existing unchanged OpenCode sessions will retain stale parsed data and incorrect failure analytics indefinitely. Increment dataVersion and document that OpenCode sessions require reparsing to backfill failure events.

---

Reviewers: 2 done | Synthesis: codex, 9s | Total: 3m9s

[roborev-ci]

roborev: Combined Review (03ade78)

No issues found.

---

Reviewers: 2 done | Synthesis: codex | Total: 2m51s

[mjacobs]

found an edge case that should be handled, updating PR soon

[roborev-ci]

roborev: Combined Review (56e82d7)

Code looks clean overall; no Medium, High, or Critical findings were reported.

---

Reviewers: 2 done | Synthesis: codex, 5s | Total: 4m7s