test: stabilize background wait synchronization - #1325
Merged
Conversation
roborev: Combined Review (
|
Member
|
looking |
The polling cooldown test used a best-effort notification to report that its first reconcile pass had returned. Under race instrumentation, the worker could send before the test began receiving, drop the signal, and turn a completed pass into a two-second timeout. Retaining the one-shot notification makes the existing cooldown assertions deterministic without changing production scheduling behavior. Co-authored-by: Marius van Niekerk <marius.v.niekerk@gmail.com> Signed-off-by: Marius van Niekerk <marius.v.niekerk@gmail.com>
The Windows job showed the fixed delay could let background startup race ahead before the incompatible runtime was published, exercising a fresh launch instead of the replacement branch. Gate publication on entry into the startup wait so the test deterministically observes and replaces the runtime it is meant to cover.
wesm
force-pushed
the
fix/race-ci-cooldown-signal
branch
from
August 2, 2026 00:19
92a4709 to
c833d1c
Compare
wesm
changed the title
roborev: Combined Review (
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two background timing tests depended on receiver or scheduler ordering and could exercise the wrong state under differently scheduled CI runners.
The unwatched poll cooldown test now retains its one-shot completion notification so a completed reconcile pass cannot become a timeout. The daemon replacement startup-wait test now waits until ensureBackgroundServe enters the startup wait before publishing the incompatible runtime, ensuring it exercises replacement rather than a fresh launch.
Both changes are test-only; production polling and daemon lifecycle behavior are unchanged. The race/non-race job split already exists on main via #1323.