test(artifact): serialize deadline-bound drain test - #1334
Merged
Conversation
The full-export unsettled-queue test performs repeated real SQLite and Docbank writes behind a 30-second hang guard. Running it alongside the package’s large parallel I/O cohort can exhaust that guard under CI contention even though the drain is making progress. Keep this one deadline-bound integration test out of the parallel cohort so the timeout continues to detect an actual stall without producing scheduler-dependent failures.
roborev: Combined Review (
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The unsettled-queue full-export test has a 30-second context to catch real stalls, but it also performs repeated real SQLite and Docbank writes. Since the artifact suite was parallelized, shared-runner contention can consume that deadline even while export progresses, failing both plain and race jobs at different write sites.
Keep this single deadline-bound integration test in the serial phase. Its real-store coverage, behavioral assertions, and hang guard remain intact; other artifact tests remain parallel and production behavior is unchanged.