fix: embed IANA timezone database for Windows support - #19
Merged
Conversation
Import time/tzdata in cmd/agentsview/main.go to embed the IANA timezone database in the binary. Fixes time.LoadLocation failing on Windows release builds (built with -trimpath) for any non-UTC timezone, which broke all analytics endpoints. Add non-UTC timezone test case to catch regressions. Closes #13 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
roborev: Combined Review (
|
cursor Bot
referenced
this pull request
in diazMelgarejo/periscope
Jun 1, 2026
## Summary - Import `time/tzdata` in `cmd/agentsview/main.go` to embed the IANA timezone database in the binary (~450KB) - `time.LoadLocation` fails on Windows release builds (built with `-trimpath`) for any non-UTC timezone, breaking all analytics endpoints - Add non-UTC timezone test case (`America/New_York`) to catch regressions Closes #13 ## Test plan - [x] All Go tests pass (`CGO_ENABLED=1 go test -tags fts5 ./...`) - [x] `NonUTCTimezone` test exercises `America/New_York` through the analytics handler - [x] Windows CI already in test matrix (`windows-latest`) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
time/tzdataincmd/agentsview/main.goto embed the IANA timezone database in the binary (~450KB)time.LoadLocationfails on Windows release builds (built with-trimpath) for any non-UTC timezone, breaking all analytics endpointsAmerica/New_York) to catch regressionsCloses #13
Test plan
CGO_ENABLED=1 go test -tags fts5 ./...)NonUTCTimezonetest exercisesAmerica/New_Yorkthrough the analytics handlerwindows-latest)🤖 Generated with Claude Code