Fix text selection in tool call blocks - #53
Merged
Conversation
The virtual-row onclick handler and ToolBlock button were consuming clicks needed for text selection. Skip selectOrdinal and collapse toggle when a text selection exists, and add user-select: text to the tool header button so browsers allow drag-to-select. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Adds two Playwright tests: - Verifies tool blocks expand on click and have user-select enabled - Verifies text selection suppresses collapse/expand toggle Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
roborev: Combined Review (
|
cursor Bot
pushed a commit
to diazMelgarejo/periscope
that referenced
this pull request
Jun 1, 2026
## Summary - Allow text selection inside tool call blocks by adding `user-select: text` to tool header buttons and skipping click handlers when a text selection exists - Prevents the virtual-row onclick (ordinal selection) and tool header onclick (collapse toggle) from firing when user is selecting text - Adds Playwright E2E regression tests for tool block expansion and text selection behavior ## Test plan - [x] Playwright E2E tests pass (29/29) - [ ] Manually verify text can be selected and copied inside expanded tool call blocks - [ ] Verify tool blocks still expand/collapse on plain click 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
user-select: textto tool header buttons and skipping click handlers when a text selection existsTest plan
🤖 Generated with Claude Code