fix: rename frontend package to agentsview-frontend - #573
Merged
Conversation
Drop the //go:fix inline directive from the generic Ptr test helpers in
internal/db and internal/dbtest. The go fix inliner cannot inline generic
calls ("type parameter inference is not yet supported"), so every Ptr(...)
call site raised a govet error and blocked commits.
Modernize the reverse stopper loop in sync_profile.go to slices.Backward,
the one remaining change golangci-lint --fix wanted to apply. The repo now
passes golangci-lint cleanly.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
The npm package still used the old working name agent-session-viewer. Rename it to agentsview-frontend across package.json and package-lock.json so the project name is consistent everywhere. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
roborev: Combined Review (
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The frontend npm package was still named
agent-session-viewer-frontend,the project's old working name. This renames it to
agentsview-frontendinpackage.jsonandpackage-lock.jsonso the name matches the rest of theproject (the Go module is already
go.kenn.io/agentsview). The package isprivate and referenced nowhere else, so this is an identity-only change. No
other occurrences of the old name remain in the repo.
It also clears two pre-existing
golangci-lintfailures that blocked thepre-commit hook:
//go:fix inlinedirective from the genericPtr[T]testhelpers in
internal/dbandinternal/dbtest. The Go fix inliner cannotinline generic calls ("type parameter inference is not yet supported"), so
every
Ptr(...)call site raised agoveterror.cmd/agentsview/sync_profile.goto useslices.Backward.golangci-lint run ./...now reports no issues.🤖 Generated with Claude Code