Skip to content

Adding Drafts app theme (light & dark) #116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

Jihad
Copy link

@Jihad Jihad commented May 3, 2025

Made one and thought to share it. 👋🏼

Reference in Drafts app themes directory as well:

Jihad added 2 commits May 4, 2025 01:09
ofcourse the extension is shouting.
Copy link
Owner

@kepano kepano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! A few notes based on the screenshots:

  • Internal links should use cyan
  • H4, H5, H6 should use the tx variable unless it's some convention that is special to Drafts?
  • Quoted text should use tx
  • Text in inline code should use tx
  • Checkmarks should use tx-3

See the mappings section:
https://stephango.com/flexoki

@Jihad Jihad requested a review from kepano May 4, 2025 13:41
@Jihad
Copy link
Author

Jihad commented May 4, 2025

@kepano Thanks for the feedback! Yeah added a wrong version.

Fixed!
Although unfortunately, for checkmarks, Drafts Default Syntax, considers them a "link" as it's clickable, so it follows links theme scope. Changing it would require making custom regex syntax file as well.

@Jihad
Copy link
Author

Jihad commented May 5, 2025

@kepano updated screenshots as well for easier review.

@kepano
Copy link
Owner

kepano commented May 7, 2025

I am looking at the latest screenshots and I still see a few issues.

  • Text in code blocks without syntax highlighting should use normal text color tx, right now it's using cyan
  • In your example [Google](http://www.google.com) the URL itself should be tx-2 (muted) if that's possible

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants