fix: bitmap layer fixes [WIP]#3474
Open
igorDykhta wants to merge 3 commits into
Open
Conversation
added 2 commits
May 31, 2026 22:44
Signed-off-by: Ihor Dykhta <ihordykhta@Ihors-MacBook-Pro.local>
Signed-off-by: Ihor Dykhta <ihordykhta@Ihors-MacBook-Pro.local>
Contributor
There was a problem hiding this comment.
Pull request overview
Removes custom GPU blend parameters from the BitmapLayer so that deck.gl's default blending is used, which fixes how the layer's opacity is applied. Also updates a stale code comment in the layer configurator.
Changes:
- Drop the custom
parametersblock (premultiplied-alpha blend factors) from the BitmapLayer instantiation so opacity behaves correctly. - Update a comment describing the
_imageTsre-render trick.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/layers/src/bitmap-layer/bitmap-layer.ts | Removes custom blend parameters from the deck.gl BitmapLayer to restore correct opacity behavior. |
| src/components/src/side-panel/layer-panel/layer-configurator.tsx | Updates an outdated comment to accurately describe the re-render mechanism. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Ihor Dykhta <ihordykhta@Ihors-MacBook-Pro.local>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.