-
Notifications
You must be signed in to change notification settings - Fork 130
fix: fix a bug when elastic as a provider #3904
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: SandeepD2697 <[email protected]>
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3904 +/- ##
==========================================
- Coverage 77.39% 77.37% -0.02%
==========================================
Files 220 220
Lines 11703 11708 +5
==========================================
+ Hits 9057 9059 +2
- Misses 2279 2281 +2
- Partials 367 368 +1
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
@mowies Can you please have a look at this when you got a few min |
|
We are still waiting for another bugfix before we do another release, but you can either build the image yourself for now and use that to test that everything works, or I can also provide you with an image. |
|
Can you please provide us with the image. We will try it out with it |
|
i pushed the new image here: https://github.com/users/mowies/packages/container/package/metrics-operator |
Signed-off-by: SandeepD2697 <[email protected]>



fixes a bug for #3727
Hey @mowies @odubajDT there is a small bug when using elastic as a provider. Previously we have not included the provider info now I have modified to include it. Can you please have a look at this? It is a continuation of the PR #3890