Skip to content

Conversation

@SandeepD2697
Copy link
Contributor

fixes a bug for #3727

Hey @mowies @odubajDT there is a small bug when using elastic as a provider. Previously we have not included the provider info now I have modified to include it. Can you please have a look at this? It is a continuation of the PR #3890

@SandeepD2697 SandeepD2697 requested a review from a team as a code owner March 20, 2025 15:02
@sonarqubecloud
Copy link

@SandeepD2697 SandeepD2697 changed the title fix: Fix a bug when elastic as a provider fix: fix a bug when elastic as a provider Mar 20, 2025
@codecov
Copy link

codecov bot commented Mar 21, 2025

Codecov Report

Attention: Patch coverage is 44.44444% with 5 lines in your changes missing coverage. Please review.

Project coverage is 77.37%. Comparing base (deeb73e) to head (ef98f75).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...or/controllers/common/providers/elastic/elastic.go 44.44% 4 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3904      +/-   ##
==========================================
- Coverage   77.39%   77.37%   -0.02%     
==========================================
  Files         220      220              
  Lines       11703    11708       +5     
==========================================
+ Hits         9057     9059       +2     
- Misses       2279     2281       +2     
- Partials      367      368       +1     
Files with missing lines Coverage Δ
...or/controllers/common/providers/elastic/elastic.go 47.15% <44.44%> (-0.31%) ⬇️
Flag Coverage Δ
certificate-operator 47.44% <ø> (ø)
component-tests 57.08% <ø> (ø)
lifecycle-operator 79.68% <ø> (ø)
metrics-operator 74.93% <44.44%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@SandeepD2697
Copy link
Contributor Author

@mowies Can you please have a look at this when you got a few min

@mowies mowies merged commit d6fd74d into keptn:main Mar 24, 2025
32 of 34 checks passed
@SandeepD2697
Copy link
Contributor Author

@mowies @odubajDT since we will be using elastic url to test this deployment in our organization will you be releasing a new version of Keptn with this changes included?

@mowies
Copy link
Member

mowies commented Mar 25, 2025

We are still waiting for another bugfix before we do another release, but you can either build the image yourself for now and use that to test that everything works, or I can also provide you with an image.

@SandeepD2697
Copy link
Contributor Author

Can you please provide us with the image. We will try it out with it

@mowies
Copy link
Member

mowies commented Mar 26, 2025

i pushed the new image here: https://github.com/users/mowies/packages/container/package/metrics-operator
there's one for amd64 and one for arm64.
you should be able to set the image and tag using the follow Helm values:

metricsOperator.image.registry: ghcr.io
metricsOperator.image.repository: mowies/metrics-operator
metricsOperator.image.tag: v2.1.1-next.0-<amd64 or arm64>

SandeepD2697 added a commit to SandeepD2697/lifecycle-toolkit that referenced this pull request Apr 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants