Conversation
Summary of ChangesHello @haifeng-jin, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly expands AutoKeras's capabilities by integrating robust support for structured data. It introduces specialized APIs for structured data classification and regression, complete with new input nodes, processing blocks, and intelligent preprocessors that automatically handle column types. The changes are thoroughly reflected in updated documentation and examples, making it easier for users to leverage AutoKeras for a broader range of tabular data problems. Additionally, it aligns the codebase with modern TensorFlow practices by updating Keras imports. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces significant new functionality for handling structured data in AutoKeras, including new tasks like StructuredDataClassifier and StructuredDataRegressor, along with corresponding nodes, blocks, and preprocessors. The documentation and examples have been updated comprehensively to reflect these additions. Additionally, there's a notable refactoring across the codebase to consistently use tensorflow.keras instead of standalone keras.
My review identifies a few critical issues in the new structured data pipeline, especially concerning data handling from CSV files and pandas DataFrames, which could prevent the features from working as documented. I've also pointed out a potentially breaking change in CUSTOM_OBJECTS, some inconsistencies in docstrings and error messages, and a suggestion to improve the default NaN imputation strategy.
* use data.Dataset for all * some tests passed * more tests fixed * more tests fixed. * image classifier fixed. * remove data * text fixed * removed keras_nlp * fix one hot encoder. * More tests fixed * All tests fixed. * Add structured data (#1950) * patch in progress * patch in progress 2 * progress 3 * tests runnable * remove tf usages * structured data working * all tests passed * docs works * structured data added to docs * clean ups * Run tests with torch * add grpc as a dependency * add grpc and protobuf to test install * fix the pip install grpcio * addressing comments.
Which issue(s) does this Pull Request fix?
resolves #000
Details of the Pull Request