Conversation
Summary of ChangesHello @haifeng-jin, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request aims to resolve an issue with the 'Tests' workflow badge by updating its image source URL in the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request fixes the test badge in the README by removing the hardcoded master branch from the badge URL. My feedback suggests also updating the corresponding link to remove the hardcoded branch name, making it more robust for future changes to the default branch.
| </p> | ||
|
|
||
| [](https://github.com/keras-team/autokeras/actions?query=workflow%3ATests+branch%3Amaster) | ||
| [](https://github.com/keras-team/autokeras/actions?query=workflow%3ATests+branch%3Amaster) |
There was a problem hiding this comment.
While removing ?branch=master from the badge URL is a good step towards making it resilient to default branch name changes, the link it points to still hardcodes branch:master.
To make the link also independent of the default branch name, you could point it to the workflow's main page. This page automatically shows the status for the default branch.
Consider changing the link to https://github.com/keras-team/autokeras/actions/workflows/Tests.
| [](https://github.com/keras-team/autokeras/actions?query=workflow%3ATests+branch%3Amaster) | |
| [](https://github.com/keras-team/autokeras/actions/workflows/Tests) |
Which issue(s) does this Pull Request fix?
resolves #000
Details of the Pull Request