Conversation
Summary of ChangesHello @haifeng-jin, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request marks the official release of version 3.0.0 by updating the project's version number. It significantly enhances the documentation by introducing new tutorials for structured data classification and regression, and by standardizing the Keras backend configuration across all Jupyter notebooks. Additionally, existing tutorials have been refined for clarity and conciseness, improving the overall user experience and ease of understanding. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request prepares for the 3.0.0 release by updating the version number and making significant updates to the documentation notebooks. This includes adding new tutorials for structured data classification and regression, and cleaning up existing ones. The changes are generally good, but I've found a recurring issue across all updated and new notebooks where an environment variable is set incorrectly. I've provided suggestions to fix this in each affected file.
| }, | ||
| "outputs": [], | ||
| "source": [ | ||
| "!export KERAS_BACKEND=\"torch\"\n", |
There was a problem hiding this comment.
The !export command in a Jupyter cell only sets the environment variable for the subshell of that specific command and does not persist for the notebook's kernel. To set the environment variable for the entire notebook session, you should use the %env magic command.
| "!export KERAS_BACKEND=\"torch\"\n", | |
| "%env KERAS_BACKEND=torch\n", |
| }, | ||
| "outputs": [], | ||
| "source": [ | ||
| "!export KERAS_BACKEND=\"torch\"\n", |
There was a problem hiding this comment.
The !export command in a Jupyter cell only sets the environment variable for the subshell of that specific command and does not persist for the notebook's kernel. To set the environment variable for the entire notebook session, you should use the %env magic command.
| "!export KERAS_BACKEND=\"torch\"\n", | |
| "%env KERAS_BACKEND=torch\n", |
| }, | ||
| "outputs": [], | ||
| "source": [ | ||
| "!export KERAS_BACKEND=\"torch\"\n", |
There was a problem hiding this comment.
The !export command in a Jupyter cell only sets the environment variable for the subshell of that specific command and does not persist for the notebook's kernel. To set the environment variable for the entire notebook session, you should use the %env magic command.
| "!export KERAS_BACKEND=\"torch\"\n", | |
| "%env KERAS_BACKEND=torch\n", |
| }, | ||
| "outputs": [], | ||
| "source": [ | ||
| "!export KERAS_BACKEND=\"torch\"\n", |
There was a problem hiding this comment.
The !export command in a Jupyter cell only sets the environment variable for the subshell of that specific command and does not persist for the notebook's kernel. To set the environment variable for the entire notebook session, you should use the %env magic command.
| "!export KERAS_BACKEND=\"torch\"\n", | |
| "%env KERAS_BACKEND=torch\n", |
| }, | ||
| "outputs": [], | ||
| "source": [ | ||
| "!export KERAS_BACKEND=\"torch\"\n", |
There was a problem hiding this comment.
The !export command in a Jupyter cell only sets the environment variable for the subshell of that specific command and does not persist for the notebook's kernel. To set the environment variable for the entire notebook session, you should use the %env magic command.
| "!export KERAS_BACKEND=\"torch\"\n", | |
| "%env KERAS_BACKEND=torch\n", |
| }, | ||
| "outputs": [], | ||
| "source": [ | ||
| "!export KERAS_BACKEND=\"torch\"\n", |
There was a problem hiding this comment.
The !export command in a Jupyter cell only sets the environment variable for the subshell of that specific command and does not persist for the notebook's kernel. To set the environment variable for the entire notebook session, you should use the %env magic command.
| "!export KERAS_BACKEND=\"torch\"\n", | |
| "%env KERAS_BACKEND=torch\n", |
| }, | ||
| "outputs": [], | ||
| "source": [ | ||
| "!export KERAS_BACKEND=\"torch\"\n", |
There was a problem hiding this comment.
The !export command in a Jupyter cell only sets the environment variable for the subshell of that specific command and does not persist for the notebook's kernel. To set the environment variable for the entire notebook session, you should use the %env magic command.
| "!export KERAS_BACKEND=\"torch\"\n", | |
| "%env KERAS_BACKEND=torch\n", |
| }, | ||
| "outputs": [], | ||
| "source": [ | ||
| "!export KERAS_BACKEND=\"torch\"\n", |
There was a problem hiding this comment.
The !export command in a Jupyter cell only sets the environment variable for the subshell of that specific command and does not persist for the notebook's kernel. To set the environment variable for the entire notebook session, you should use the %env magic command.
| "!export KERAS_BACKEND=\"torch\"\n", | |
| "%env KERAS_BACKEND=torch\n", |
| }, | ||
| "outputs": [], | ||
| "source": [ | ||
| "!export KERAS_BACKEND=\"torch\"\n", |
There was a problem hiding this comment.
The !export command in a Jupyter cell only sets the environment variable for the subshell of that specific command and does not persist for the notebook's kernel. To set the environment variable for the entire notebook session, you should use the %env magic command.
| "!export KERAS_BACKEND=\"torch\"\n", | |
| "%env KERAS_BACKEND=torch\n", |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1956 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 49 49
Lines 2317 2317
=========================================
Hits 2317 2317
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
1 participant
No description provided.